Skip to content

Commit

Permalink
Revert "fix: Use correct paths for cluster urls (#3652)" (#3660)
Browse files Browse the repository at this point in the history
This reverts commit 51f2213.
  • Loading branch information
OliwiaGowor authored Feb 5, 2025
1 parent 0e03ec3 commit e2d9f8a
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/components/CustomResources/CustomResources.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function CustomResources({
}) {
const { group, names } = crd.spec;
const name = names.plural;
const customUrl = useCustomResourceUrl(crd);
const customUrl = useCustomResourceUrl(crd, true);
const { namespace } = useUrl();
const resourceUrl =
namespace && namespace !== '-all-'
Expand Down
9 changes: 7 additions & 2 deletions src/resources/CustomResourceDefinitions/CRCreate.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@ function CRCreate({
const [initialResource] = useState(
initialCustomResource || createTemplate(crd),
);
const customUrl = useCustomResourceUrl(crd);
const currUrl = window.location.href;

const customUrl = useCustomResourceUrl(
crd,
currUrl.includes('customresources/'),
);

const navigate = useNavigate();
const { nextQuery, currentQuery } = usePrepareLayout(layoutNumber);
const goToLayoutQuery = customUrl(cr)?.includes('customresources/')
const goToLayoutQuery = customUrl(cr).includes('customresources/')
? nextQuery
: currentQuery;

Expand Down
10 changes: 7 additions & 3 deletions src/resources/CustomResourceDefinitions/useCustomResourceUrl.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { useRecoilValue } from 'recoil';
import { allNodesSelector } from 'state/navigation/allNodesSelector';
import { useUrl } from 'hooks/useUrl';

export function useCustomResourceUrl(crd) {
const { clusterUrl, namespaceUrl } = useUrl();
export function useCustomResourceUrl(crd, columnLayout = false) {
const { resourceUrl, clusterUrl, namespaceUrl } = useUrl();
const clusterNodes = useRecoilValue(allNodesSelector).filter(
node => !node.namespaced,
);
Expand All @@ -22,10 +22,14 @@ export function useCustomResourceUrl(crd) {
);

if (clusterNode) {
return resourceUrl(cr, { resourceType: clusterNode.pathSegment });
} else if (namespaceNode && !columnLayout) {
return resourceUrl(cr, { resourceType: namespaceNode.pathSegment });
} else if (crd.spec.scope === 'Cluster') {
return clusterUrl(
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
);
} else if (namespaceNode) {
} else {
return namespaceUrl(
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
{ namespace: cr.metadata.namespace },
Expand Down

0 comments on commit e2d9f8a

Please sign in to comment.