Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add statistical card to extensibility #2962

Merged
merged 22 commits into from
Jun 21, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Jun 10, 2024

Description

Changes proposed in this pull request:

  • Add Statistical Card to extensibility

How to test it

On example of HPA, put it in body section:

      - name: Metrics
        source: status.currentMetrics.resource.current
        widget: StatisticalCard
        mainValue:
          name: Average Value
          source: $item.averageValue
        children:
          - name: AvgUtilization
            source: status.currentMetrics.resource.current.averageUtilizationN  #intentional typo
          - name: Average Utilization
            source: $item.averageUtilization
        targets:
          - location: HorizontalPodAutoscaler
            slot: cards
      - name: Replicas
        source: status
        widget: StatisticalCard
        allNamespaceURL: false
        resourceURL: pods
        mainValue:
          name: Current replicas
          source: $item.currentReplicas
        children:
          - name: Desired replicas
            source: $item.desiredReplicas   

Related issue(s)

#2763

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2024
@dbadura dbadura linked an issue Jun 10, 2024 that may be closed by this pull request
9 tasks
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2024
@dbadura dbadura force-pushed the statistical-card-extensibility branch 6 times, most recently from 6f40866 to 0e27dbf Compare June 10, 2024 13:11
@dbadura dbadura marked this pull request as ready for review June 10, 2024 13:11
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
@dbadura dbadura force-pushed the statistical-card-extensibility branch from 0e27dbf to 3b90508 Compare June 11, 2024 07:42
@dbadura dbadura changed the title Add statistical card to extensibility feat: Add statistical card to extensibility Jun 11, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2024
@mrCherry97 mrCherry97 assigned mrCherry97 and unassigned akucharska Jun 19, 2024
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Statistical Card is added threw injection there should be Learn more which is a link to ns all for this resource, or to this resource if it's cluster wide resource.
image

Or we need to add option to add learn more prop to extensibility to allow the user to modify this link.

mrCherry97
mrCherry97 previously approved these changes Jun 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 20, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 21, 2024
@akucharska
Copy link
Contributor

/retest

mrCherry97
mrCherry97 previously approved these changes Jun 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 21, 2024
@@ -93,14 +95,15 @@ This is an exaple of kind only:

### ConditionList

The condition List widget renders the conditions as an expandable list with condition details.
The condition List widget renders the conditions as an expandable list with condition details. This widget is primarily designed to be used in overview section **data.details.status**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The condition List widget renders the conditions as an expandable list with condition details. This widget is primarily designed to be used in overview section **data.details.status**
The condition List widget renders the conditions as an expandable list with condition details. This widget is primarily designed for the overview section **data.details.status**.

docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
docs/extensibility/50-list-and-details-widgets.md Outdated Show resolved Hide resolved
Co-authored-by: Małgorzata Świeca <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 21, 2024
@mrCherry97
Copy link
Contributor

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 21, 2024
@kyma-bot kyma-bot merged commit 2c7bb2c into kyma-project:main Jun 21, 2024
12 checks passed
@dbadura dbadura deleted the statistical-card-extensibility branch June 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements for Statistical Cards in Cluster Overview and Busola Extensions
5 participants