Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove COLUMN_LAYOUT feature flag #2984

Merged
merged 16 commits into from
Jun 26, 2024
Merged

feat: remove COLUMN_LAYOUT feature flag #2984

merged 16 commits into from
Jun 26, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Jun 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • removed COLUMN_LAYOUT flag
  • fixed jumping columns in column layout
  • adjusted logic for checking if form is opened
  • adjusted tests
    Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review June 25, 2024 12:53
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@mrCherry97 mrCherry97 self-assigned this Jun 26, 2024
mrCherry97
mrCherry97 previously approved these changes Jun 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 26, 2024
@mrCherry97
Copy link
Contributor

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 26, 2024
@OliwiaGowor OliwiaGowor removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 26, 2024
@kyma-bot kyma-bot merged commit 6e7a372 into kyma-project:main Jun 26, 2024
12 checks passed
@OliwiaGowor OliwiaGowor deleted the remove-column-layout-flag branch July 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OliwiaGowor @kyma-bot @mrCherry97