Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not able to add modules when there are none initially #3037

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: Not able to add modules when there are none initially #3037

merged 2 commits into from
Jul 3, 2024

Conversation

OliwiaGowor
Copy link
Contributor

Description

Changes proposed in this pull request:

  • fixed not being able to add modules when there are none initially

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@OliwiaGowor OliwiaGowor marked this pull request as ready for review July 3, 2024 08:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 3, 2024
@OliwiaGowor OliwiaGowor linked an issue Jul 3, 2024 that may be closed by this pull request
Not able to add modules when there are none initially #3038
Closed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2024
@kyma-bot kyma-bot merged commit dc381b7 into kyma-project:main Jul 3, 2024
11 checks passed
@OliwiaGowor OliwiaGowor deleted the fix-no-selected-modules branch July 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to add modules when there are none initially
3 participants
@OliwiaGowor @kyma-bot @mrCherry97