Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect permissions for restricted users #3045

Merged
merged 4 commits into from
Jul 8, 2024
Merged

fix: incorrect permissions for restricted users #3045

merged 4 commits into from
Jul 8, 2024

Conversation

chriskari
Copy link
Contributor

Description

Changes proposed in this pull request:

  • restricted users with cluster-wide access to Config Maps, fetched on a cluster level
  • restricted user with no cluster-wide access to Config Maps, but full access on namespace level, fetch namespace-wide config maps

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jul 5, 2024
@chriskari chriskari linked an issue Jul 5, 2024 that may be closed by this pull request
Incorrect permission check for restricted users #2538
Closed
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2024
@kyma-bot kyma-bot merged commit f45cd74 into kyma-project:main Jul 8, 2024
13 checks passed
@chriskari chriskari deleted the fix-incorrect-permissions branch October 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect permission check for restricted users
3 participants
@chriskari @OliwiaGowor @kyma-bot