Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI5 toast component #3111

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix: UI5 toast component #3111

merged 2 commits into from
Aug 9, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Aug 7, 2024 •
edited by mrCherry97
Loading

Description
see related issue

Changes proposed in this pull request:

  • switched toasts from UI5 messagestrip to UI5 toast

Related issue(s)
#3000

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@chriskari chriskari linked an issue Aug 7, 2024 that may be closed by this pull request
UXC-10: Toasts should used Toast component from UI5 instead of MessageStrip #3000
Closed
2 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot merged commit dcc7cb4 into kyma-project:main Aug 9, 2024
13 checks passed
@chriskari chriskari deleted the UI5-toasts branch October 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UXC-10: Toasts should used Toast component from UI5 instead of MessageStrip
3 participants
@chriskari @OliwiaGowor @kyma-bot