Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add external nodes for statics #3115

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Aug 8, 2024

Description

Changes proposed in this pull request:

  • added external nodes for statics
  • adjusted documentation

Related issue(s)
#3112

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Aug 8, 2024
@OliwiaGowor OliwiaGowor linked an issue Aug 8, 2024 that may be closed by this pull request
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 8, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review August 8, 2024 10:11
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
chriskari
chriskari previously approved these changes Aug 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
docs/extensibility/statics.md Outdated Show resolved Hide resolved
docs/extensibility/statics.md Outdated Show resolved Hide resolved
docs/extensibility/statics.md Outdated Show resolved Hide resolved
docs/extensibility/statics.md Outdated Show resolved Hide resolved
docs/extensibility/statics.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
@kyma-bot kyma-bot merged commit 1bae12f into kyma-project:main Aug 8, 2024
13 checks passed
@OliwiaGowor OliwiaGowor deleted the statics-ext-nodes branch September 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External links in static extension
4 participants