Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disableOnEdit Text widget #3117

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

kevin-kho
Copy link
Contributor

@kevin-kho kevin-kho commented Aug 8, 2024

Description

Changes proposed in this pull request:

  • Adds a disableOnEdit property for Text widgets. Similar to the Name widget.

Related issue(s)

Fixes issue #3116 , raised by myself. Reasoning for the feature is in the issue.

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 8, 2024
@mrCherry97
Copy link
Contributor

hi @kevin-kho
thanks for the contribution, please fill up the description and mark checkboxes after that PR will be reviewed.

@mrCherry97 mrCherry97 linked an issue Aug 19, 2024 that may be closed by this pull request
@mrCherry97 mrCherry97 changed the title feature: disableOnEdit Text widget feat: disableOnEdit Text widget Aug 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 19, 2024
@kevin-kho
Copy link
Contributor Author

hi @kevin-kho thanks for the contribution, please fill up the description and mark checkboxes after that PR will be reviewed.

Done. I've updated the description and marked the checkboxes. I did have to update the PR description to retrigger the pipelines as the run-namespace-test was failing due to timeout on test-jobs.spec.js

@kyma-bot kyma-bot merged commit 8fb0252 into kyma-project:main Aug 20, 2024
71 of 76 checks passed
@kevin-kho kevin-kho deleted the kh-text-disableEdit-feature branch August 20, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disableOnEdit for Text widgets
5 participants