Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --oidc-use-access-token flag #3292

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

v0lkc
Copy link
Contributor

@v0lkc v0lkc commented Aug 22, 2024

Description

Changes proposed in this pull request:

  • use the access_token instead of the id_token if the kubeconfig contains the --oidc-use-access-token flag. This is in particular helpful if xsuaa is used as auth endpoint

Related issue(s)

Implements #3132

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 22, 2024
@kyma-bot
Copy link
Contributor

Hi @v0lkc. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2024
@v0lkc v0lkc changed the title Fix/3132 feat: support --oidc-use-access-token flag Aug 22, 2024
@v0lkc
Copy link
Contributor Author

v0lkc commented Aug 22, 2024

/test all

@kyma-bot
Copy link
Contributor

@v0lkc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chriskari chriskari self-assigned this Aug 26, 2024
@v0lkc v0lkc requested a review from chriskari August 27, 2024 12:21
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 27, 2024
@chriskari chriskari linked an issue Aug 27, 2024 that may be closed by this pull request
@kyma-bot kyma-bot merged commit 4bb55b7 into kyma-project:main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support newly added kubelogin cli flag --oidc-use-access-token
3 participants