Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhance Secrets #3304

Merged
merged 5 commits into from
Aug 28, 2024
Merged

feat: Enhance Secrets #3304

merged 5 commits into from
Aug 28, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Aug 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • added Events to Secret details

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
@OliwiaGowor OliwiaGowor mentioned this pull request Aug 26, 2024
Closed
58 tasks
@OliwiaGowor OliwiaGowor marked this pull request as ready for review August 27, 2024 06:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
@mrCherry97 mrCherry97 self-assigned this Aug 28, 2024
mrCherry97
mrCherry97 requested changes Aug 28, 2024
View reviewed changes
src/resources/Secrets/SecretDetails.js Outdated
const Configuration = secret => (
<UI5Panel
fixed
keyComponent={'storageclass-configuration'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storageclass ?

src/resources/Secrets/SecretDetails.js Outdated
<UI5Panel
fixed
keyComponent={'storageclass-configuration'}
title={t('storage-classes.headers.configuration')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to common.headers instead of using storage-class and also adjust the resort of the places in app where storage-class translation is used

@OliwiaGowor OliwiaGowor requested a review from a team as a code owner August 28, 2024 07:42
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 28, 2024
@kyma-bot kyma-bot merged commit 159d038 into kyma-project:main Aug 28, 2024
13 checks passed
@OliwiaGowor OliwiaGowor deleted the enhance-secrets branch September 16, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OliwiaGowor @kyma-bot @mrCherry97 @nataliasitko