Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header actions in namespace overview are truncated after relaoding the page #3559

Closed
wants to merge 2 commits into from
Closed

fix: header actions in namespace overview are truncated after relaoding the page #3559

wants to merge 2 commits into from

Conversation

KonradPietocha
Copy link
Contributor

@KonradPietocha KonradPietocha commented Dec 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fixes header action clipping,
  • Changes some js files to tsx,
  • Reduces the number of iterations by using conditions in one filter

Related issue(s)
Closes #3505

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2024
@KonradPietocha KonradPietocha changed the title fix: 3505 header actions in namespace overview are truncated after relaoding the page fix: header actions in namespace overview are truncated after relaoding the page Dec 27, 2024
@KonradPietocha KonradPietocha deleted the branch kyma-project:3505-header-actions-in-namespace-overview-are-truncated-after-relaoding-the-page December 27, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska Awaiting requested review from akucharska

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97

@dbadura dbadura Awaiting requested review from dbadura

@chriskari chriskari Awaiting requested review from chriskari

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradPietocha @kyma-bot