fix: resoruces should be displayed correctly. #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
requested review from
akucharska,
mrCherry97,
chriskari and
OliwiaGowor
as code owners
kyma-bot
added
cla: yes
dbadura
force-pushed
the
fix-resources-display
branch
from
90deba1 to
a719e67
Compare
src/shared/helpers/resources.js
Outdated
| const coreValue = ( | ||
| Math.round((+amount + Number.EPSILON) * 100) / 100 | ||
| ).toFixed(fixed); | ||
| if (unit !== '' && prefixMap[unit]) { |
There was a problem hiding this comment.
Are null, undefined and 0 possible here and acceptable? If not, we can just use: "if (unit && prefixMap[unit])"
src/shared/helpers/resources.js
Outdated
| const value = (amount / prefixMap[unit]).toFixed(fixed); | ||
| return { | ||
| value: value, | ||
| string: `${value}${infix}${unit}`, |
There was a problem hiding this comment.
Maybe it would be better to change the names to: "value" and "valueWithUnit" or something like that?
There was a problem hiding this comment.
I think that we can remove the whole object and return just string.
KonradPietocha
approved these changes
Jan 20, 2025
akucharska
approved these changes
Jan 21, 2025
|
New changes are detected. LGTM label has been removed. |
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Definition of done
backlog#4567