Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reuse POC's api and utils #3616

Merged
merged 5 commits into from
Feb 4, 2025
Merged

feat: Reuse POC's api and utils #3616

merged 5 commits into from
Feb 4, 2025

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Jan 21, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • reused most of the work that has been done in the POC (API and utils)
  • transformed files to use Typescript

Related issue(s)
Closes #3600

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@chriskari chriskari added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@chriskari
Copy link
Contributor Author

Wait for the POC UI PR to be merged and adjust the TODOs from this PR, before merging this one.

@chriskari chriskari changed the title feat: reuse POC's API calls and utils feat: reuse POC's api and utils Jan 21, 2025
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@chriskari chriskari added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kyma companion Related to all activities around the Kyma Companion labels Jan 21, 2025
@chriskari chriskari changed the title feat: reuse POC's api and utils feat: Reuse POC's api and utils Jan 31, 2025
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
@OliwiaGowor OliwiaGowor merged commit 6f47a06 into kyma-project:main Feb 4, 2025
54 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. kyma companion Related to all activities around the Kyma Companion lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Kyma Companion to UI5v2
3 participants
@chriskari @OliwiaGowor @kyma-bot