Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Kyma Modules move queries to separate file #3637

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Jan 28, 2025

Description

Changes proposed in this pull request:

  • move kyma, mt, mrm queries to separate file,
  • fix ass resource counter,
  • minor improments.

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review January 28, 2025 13:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025
@mrCherry97 mrCherry97 changed the title move queries to separate file refactor: Kyma Modules move queries to separate file Jan 28, 2025
@@ -233,7 +231,7 @@ export default function KymaModulesList({
)}
{checkBeta(currentModule, currentModuleReleaseMeta) ? (
<Badge style={spacing.sapUiTinyMarginBegin}>
{t('kyma-modules.beta')}
{t('kyma-moduleTemplates.beta')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this in en.yaml

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 28, 2025
@mrCherry97
Copy link
Contributor

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 79d7b67 into kyma-project:main Jan 28, 2025
15 checks passed
@dbadura dbadura deleted the refactor-modules branch January 29, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants