feat: Adjust companion to new designs #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskari
requested review from
a team,
akucharska,
mrCherry97,
dbadura and
OliwiaGowor
as code owners
kyma-bot
added
cla: yes
chriskari
changed the title
kyma-bot
added
size/XL
OliwiaGowor
reviewed
Feb 6, 2025
Comment on lines
17
to
25
| // --sapNeutralColor | ||
| background-color: rgba(#788fa6, 0.2); | ||
| border-radius: 8px 8px 8px 0; | ||
| } | ||
|
|
||
| .right-aligned { | ||
| align-self: flex-end; | ||
| background-color: var(--sapContent_Illustrative_Color1); | ||
| // --sapContent_Illustrative_Color1 | ||
| background-color: rgba(#5d36ff, 0.2); |
There was a problem hiding this comment.
Why can't we use the variables?
There was a problem hiding this comment.
Directly applying opacity to the ui5 defined color is not possible, because this only works for rgb colors and ui5 colors are defined in hexadecimal. Also I couldn't apply opacity to the element as this affects all of its children as well. But I just checked again and found another approach that directly uses the color, so thanks for leaving this comment and you can have a look again 😄
OliwiaGowor
previously approved these changes
Feb 6, 2025
grego952
reviewed
Feb 6, 2025
public/i18n/en.yaml
Outdated
| @@ -761,7 +761,8 @@ kyma-companion: | |||
| subtitle: A temporary interruption occured. Please try again. | |||
| introduction1: Hello there, | |||
| introduction2: How can I help you? | |||
| placeholder: Type something | |||
| placeholder: Message Joule | |||
| disclaimer: Joule is powered by generative AI and all output should be reviewed before use. Please do not enter any sensitive personal data, and avoid entering any other personal data you do not wish to be processed. | |||
There was a problem hiding this comment.
Suggested change
| disclaimer: Joule is powered by generative AI and all output should be reviewed before use. Please do not enter any sensitive personal data, and avoid entering any other personal data you do not wish to be processed. | |
| disclaimer: Joule is powered by generative AI, and the output must be reviewed before use. Do not enter any sensitive personal data, and avoid entering any other data you do not wish to be processed. |
grego952
approved these changes
Feb 6, 2025
OliwiaGowor
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3601
Definition of done
backlog#4567