Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump UI5 packages and add accessibleName for Tables #3657

Merged
merged 11 commits into from
Feb 5, 2025
Merged

fix: Bump UI5 packages and add accessibleName for Tables #3657

merged 11 commits into from
Feb 5, 2025

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Feb 4, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • bumped UI5 packages
  • adjusted tests

Related issue(s)

Closes #3140, #3139
Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2025
@OliwiaGowor OliwiaGowor marked this pull request as ready for review February 4, 2025 12:51
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
@OliwiaGowor OliwiaGowor linked an issue Feb 4, 2025 that may be closed by this pull request
ACC-263.1 (Level A) _ Modify Modules _ Text _ No heading level provided for a heading #3139
Closed
@OliwiaGowor OliwiaGowor changed the title chore: Bump UI5 packages fix: Bump UI5 packages and add accessibleName for Tables Feb 5, 2025
@mrCherry97 mrCherry97 self-assigned this Feb 5, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 5, 2025
@mrCherry97 mrCherry97 merged commit 3400bd8 into kyma-project:main Feb 5, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@OliwiaGowor @mrCherry97 @kyma-bot