Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: Use correct paths for cluster urls" #3660

Merged
merged 1 commit into from
Feb 5, 2025
+15 −6
Merged

revert: "fix: Use correct paths for cluster urls" #3660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CustomResources/CustomResources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function CustomResources({
}) {
const { group, names } = crd.spec;
const name = names.plural;
const customUrl = useCustomResourceUrl(crd);
const customUrl = useCustomResourceUrl(crd, true);
const { namespace } = useUrl();
const resourceUrl =
namespace && namespace !== '-all-'
Expand Down
9 changes: 7 additions & 2 deletions src/resources/CustomResourceDefinitions/CRCreate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@ function CRCreate({
const [initialResource] = useState(
initialCustomResource || createTemplate(crd),
);
const customUrl = useCustomResourceUrl(crd);
const currUrl = window.location.href;

const customUrl = useCustomResourceUrl(
crd,
currUrl.includes('customresources/'),
);

const navigate = useNavigate();
const { nextQuery, currentQuery } = usePrepareLayout(layoutNumber);
const goToLayoutQuery = customUrl(cr)?.includes('customresources/')
const goToLayoutQuery = customUrl(cr).includes('customresources/')
? nextQuery
: currentQuery;

Expand Down
10 changes: 7 additions & 3 deletions src/resources/CustomResourceDefinitions/useCustomResourceUrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { useRecoilValue } from 'recoil';
import { allNodesSelector } from 'state/navigation/allNodesSelector';
import { useUrl } from 'hooks/useUrl';

export function useCustomResourceUrl(crd) {
const { clusterUrl, namespaceUrl } = useUrl();
export function useCustomResourceUrl(crd, columnLayout = false) {
const { resourceUrl, clusterUrl, namespaceUrl } = useUrl();
const clusterNodes = useRecoilValue(allNodesSelector).filter(
node => !node.namespaced,
);
Expand All @@ -22,10 +22,14 @@ export function useCustomResourceUrl(crd) {
);

if (clusterNode) {
return resourceUrl(cr, { resourceType: clusterNode.pathSegment });
} else if (namespaceNode && !columnLayout) {
return resourceUrl(cr, { resourceType: namespaceNode.pathSegment });
} else if (crd.spec.scope === 'Cluster') {
return clusterUrl(
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
);
} else if (namespaceNode) {
} else {
return namespaceUrl(
`customresources/${crd.metadata.name}/${cr.metadata.name}`,
{ namespace: cr.metadata.namespace },
Expand Down
Loading