Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove hide-shadow #3666

Merged
merged 1 commit into from
Feb 6, 2025
Merged

chore: Remove hide-shadow #3666

merged 1 commit into from
Feb 6, 2025

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Feb 6, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • chore: Remove hide-shadow

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
@mrCherry97 mrCherry97 changed the title chore: remove hide-shadow chore: Remove hide-shadow Feb 6, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review February 6, 2025 09:03
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 6, 2025
@mrCherry97
Copy link
Contributor Author

/override tide

@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 6, 2025

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 6d2b29d into kyma-project:main Feb 6, 2025
52 of 61 checks passed
@mrCherry97 mrCherry97 deleted the chore-remove-hide-shadow branch February 6, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @kyma-bot @OliwiaGowor