Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sap.ids: prefix to admin users #71

Merged
merged 1 commit into from
Sep 30, 2024
Merged

add sap.ids: prefix to admin users #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions controllers/cfapi_auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import (
"sigs.k8s.io/controller-runtime/pkg/log"
)

const OIDC_USER_PREFIX = "sap.ids:"

func (r *CFAPIReconciler) getUserClusterAdmins(ctx context.Context) ([]rbacv1.Subject, error) {
subjects := []rbacv1.Subject{}
crblist := &rbacv1.ClusterRoleBindingList{}
Expand Down Expand Up @@ -67,6 +69,13 @@ func (r *CFAPIReconciler) assignCfAdministrators(ctx context.Context, subjects [
}
}

//add prefix sap.ids: for all user names without prefix
for _, subject := range _subjects {
if subject.Kind == "User" && !strings.HasPrefix(subject.Name, OIDC_USER_PREFIX) {
subject.Name = OIDC_USER_PREFIX + subject.Name
}
}

rb := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: "cfapi-admins-binding",
Expand Down
Loading