Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NfsVolumeBackup): Short circuit reconciliation loop if completed #1035

Merged
merged 3 commits into from
Feb 20, 2025
Merged

fix(NfsVolumeBackup): Short circuit reconciliation loop if completed #1035

merged 3 commits into from
Feb 20, 2025

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Short circuiting reconciliation loop if status is Ready or Failed.
  • Mark the status to failed if a new backup exists.

Related issue(s)

Part of #https://github.tools.sap/kyma/cloud-manager-infra/issues/28

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2025
@ravi-shankar-sap ravi-shankar-sap changed the title fix(GcpNfsVolumeBackup): Short circuit reconciliation loop if completed fix(NfsVolumeBackup): Short circuit reconciliation loop if completed Feb 19, 2025
@ravi-shankar-sap ravi-shankar-sap marked this pull request as ready for review February 19, 2025 19:50
@ravi-shankar-sap ravi-shankar-sap requested a review from a team as a code owner February 19, 2025 19:50
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 19, 2025
abalaie
abalaie approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 20, 2025
@ravi-shankar-sap ravi-shankar-sap enabled auto-merge (squash) February 20, 2025 00:17
@ravi-shankar-sap ravi-shankar-sap merged commit a00b4fa into kyma-project:main Feb 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalaie abalaie abalaie approved these changes

Assignees

@abalaie abalaie

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-shankar-sap @abalaie @kyma-bot