feat(GCPVpcPeering) Delete VPC Peering #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
bru-jer-work
force-pushed
the
gcp-vpcpeering-delete
branch
from
021990d to
23051e3
Compare
kyma-bot
added
size/XXL
bru-jer-work
force-pushed
the
gcp-vpcpeering-delete
branch
2 times, most recently
from
9c5ba79 to
5da24fe
Compare
vandjelk
reviewed
Aug 1, 2024
| logger := composed.LoggerFromCtx(ctx) | ||
|
|
||
| if state.kymaVpcPeering != nil { | ||
| return nil, ctx |
There was a problem hiding this comment.
not a big deal but you can return nil, nil since ctx is not modified and avoid unnecessary ctx assignmet in
# pkg/composed/action.go
if nextCtx != nil {
currentCtx = nextCtx
}
11bfbdf to
d52c95b
Compare
bru-jer-work
force-pushed
the
gcp-vpcpeering-delete
branch
from
d52c95b to
22624b8
Compare
dushanpantic
approved these changes
Aug 7, 2024
| return fmt.Sprintf("https://www.googleapis.com/compute/v1/projects/%s/global/networks/%s", project, vpc) | ||
| } | ||
|
|
||
| func (s *vpcPeeringStore) CreateRemoteVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (*compute.Operation, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *vpcPeeringStore) CreateRemoteVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (*compute.Operation, error) { | |
| func (s *vpcPeeringStore) CreateRemoteVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (error) { |
Is operation used anywhere? If not, perhaps we can omit returning it all together
There was a problem hiding this comment.
You are right, in the beginning I was using the operation instead of each peering object and checking if it was done or not but now we don't need it for anything else. I am doing some tests with the guid on the kyma as the peeringName and will remove these :) Thanks for the heads up
| return new(compute.Operation), nil | ||
| } | ||
|
|
||
| func (s *vpcPeeringStore) CreateKymaVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (*compute.Operation, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *vpcPeeringStore) CreateKymaVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (*compute.Operation, error) { | |
| func (s *vpcPeeringStore) CreateKymaVpcPeering(ctx context.Context, remotePeeringName string, remoteVpc string, remoteProject string, importCustomRoutes bool, kymaProject string, kymaVpc string) (error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: