Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AwsRedisInstance): add SKR reconciler #359

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

dushanpantic
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adds SKR Reconciler for AwsRedisInstance

Not in this PR:

  • User specs for Redis configuration

Related issue(s)

@dushanpantic dushanpantic requested a review from a team as a code owner July 19, 2024 10:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2024
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 19, 2024
@kyma-bot kyma-bot merged commit 4eae32f into kyma-project:main Jul 19, 2024
7 checks passed
@dushanpantic dushanpantic deleted the skr-aws-redis branch July 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants