Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preventing zombie filestore backups and patching status instead… #554

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

abalaie
Copy link
Contributor

@abalaie abalaie commented Aug 31, 2024

… of update

Description

Changes proposed in this pull request:

  • Setting id and location in status before creating Filestore backup
  • Using patch instead of update when saving changes in status
  • Using patch for adding finalizers

Related issue(s)

Resolves #531

@abalaie abalaie requested a review from a team as a code owner August 31, 2024 00:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2024
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 3, 2024
@abalaie abalaie force-pushed the ab-531 branch 7 times, most recently from 5fb323a to 3a3cde5 Compare September 4, 2024 19:49
@abalaie abalaie added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
@abalaie abalaie force-pushed the ab-531 branch 4 times, most recently from f6ca8e5 to 63e77a8 Compare September 4, 2024 22:43
@abalaie abalaie removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
Copy link
Contributor

@ravi-shankar-sap ravi-shankar-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 5, 2024
@kyma-bot kyma-bot merged commit 62dcaf7 into kyma-project:main Sep 5, 2024
11 checks passed
@abalaie abalaie deleted the ab-531 branch September 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zombie GCP Filestore Backups
3 participants