Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AzureVpcPeering): updates docs and samples #561

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/samples/cloud-control_v1beta1_vpcpeering.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@ spec:
name: skr-vpcpeering-sample
vpcPeering:
azure:
allowVnetAccess: True
remoteResourceGroup: MyResourceGroup
remoteVnet: /subscriptions/e492e533-1d28-4dde-85f7-0399ec55565f/resourceGroups/MyResourceGroup/providers/Microsoft.Network/virtualNetworks/MyVnet
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ metadata:
app.kubernetes.io/created-by: cloud-manager
name: azurevpcpeering-sample
spec:
allowVnetAccess: true
remoteResourceGroup: MyResourceGroup
remoteVnet: /subscriptions/9c05f3c1-314b-4c4b-bfff-b5a0650177cb/resourceGroups/MyResourceGroup/providers/Microsoft.Network/virtualNetworks/MyVnet
2 changes: 0 additions & 2 deletions docs/user/resources/04-40-10-azure-vpc-peering.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ This table lists the parameters of the given resource together with their descri

| Parameter | Type | Description |
|-------------------------|--------|-----------------------------------------------------------------------------------------------------------------------------------------------|
| **allowVnetAccess** | bool | Specifies whether the VMs in the local virtual network space can access the VMs in the remote virtual network space and vice versa. |
| **remotePeeringName** | string | Specifies the name of the VNet peering in the remote subscription. |
| **remoteResourceGroup** | string | Specifies the name of the resource group in the remote subscription. |
| **remoteVnet** | string | Specifies the ID of the VNet in the remote subscription. |
Expand Down Expand Up @@ -54,7 +53,6 @@ kind: AzureVpcPeering
metadata:
name: peering-to-my-vnet
spec:
allowVnetAccess: true
remotePeeringName: peering-to-my-kyma
remoteResourceGroup: MyResourceGroup
remoteVnet: /subscriptions/afdbc79f-de19-4df4-94cd-6be2739dc0e0/resourceGroups/WestEurope/providers/Microsoft.Network/virtualNetworks/MyVnet
Expand Down
3 changes: 1 addition & 2 deletions docs/user/tutorials/01-30-azure-vpc-peering.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Use VPC peering in Azure
# Create VPC Peering in Azure

This tutorial explains how to create a VPC peering connection between a remote VPC network and Kyma in Azure. The tutorial
assumes that the Cloud Manager module is enabled in your Kyma cluster. Follow the steps from this tutorial to create a new resource group, VPC
Expand Down Expand Up @@ -80,7 +80,6 @@ the steps that create those resources.
metadata:
name: peering-to-my-vnet
spec:
allowVnetAccess: true
remotePeeringName: peering-to-my-kyma
remoteResourceGroup: $RESOURCE_GROUP_NAME
remoteVnet: $VNET_ID
Expand Down
2 changes: 1 addition & 1 deletion docs/user/tutorials/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ Browse the Cloud Manager tutorials to learn how to create and use cloud resource

* [Use RWX Volumes in AWS](./01-10-aws-nfs-volume.md)
* [Use RWX Volumes in GCP](./01-20-gcp-nfs-volume.md)
* [Use VPC peering in Azure](./01-30-azure-vpc-peering.md)
* [Create VPC Peering in Azure](./01-30-azure-vpc-peering.md)
* [Create VPC Peering in GCP](./01-30-gcp-vpc-peering.md)
* [Create Redis Instance in GCP](./01-60-gcp-redis-instance.md)
Loading