Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GCP Config to use the config pkg similar to other configs #591

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • GCP Config to use config pkg to support files nd dynamic reloading.

Related issue(s)
#575

@ravi-shankar-sap ravi-shankar-sap requested a review from a team as a code owner September 7, 2024 01:48
@CLAassistant
Copy link

CLAassistant commented Sep 7, 2024

CLA assistant check
All committers have signed the CLA.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 7, 2024
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 9, 2024
@kyma-bot kyma-bot merged commit 35eb939 into kyma-project:main Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants