Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add NFS, Redis, and VPC peering feature description #918

Merged
merged 22 commits into from
Feb 4, 2025
Merged

docs: Add NFS, Redis, and VPC peering feature description #918

merged 22 commits into from
Feb 4, 2025

Conversation

mmitoraj
Copy link
Contributor

@mmitoraj mmitoraj commented Dec 20, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added the NFS feature description based on the input from Nikola
  • Added the Redis feature description based on the input from Nikola
  • Added the VPC peering feature description based on the input from Nikola
  • Added the user architecture diagram based on the input from Nikola

Related issue(s)

@mmitoraj mmitoraj added documentation Improvements or additions to documentation area/documentation Issues or PRs related to documentation labels Dec 20, 2024
@mmitoraj mmitoraj requested a review from a team as a code owner December 20, 2024 14:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2024
mmitoraj
mmitoraj commented Dec 20, 2024
View reviewed changes
abalaie
abalaie reviewed Jan 6, 2025
View reviewed changes
mmitoraj
mmitoraj commented Jan 10, 2025
View reviewed changes
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2025
@mmitoraj mmitoraj changed the title docs: Add NFS feature description docs: Add NFS, Redis, and VPC peering feature description Jan 31, 2025
vandjelk
vandjelk previously approved these changes Feb 3, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 3, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 3, 2025
IwonaLanger
IwonaLanger reviewed Feb 4, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 4, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 4, 2025
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 4, 2025

New changes are detected. LGTM label has been removed.

@mmitoraj mmitoraj enabled auto-merge (squash) February 4, 2025 14:46
@mmitoraj mmitoraj merged commit 167e1eb into kyma-project:main Feb 4, 2025
14 checks passed
@mmitoraj mmitoraj deleted the features-descr branch February 4, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dushanpantic dushanpantic dushanpantic left review comments

@abalaie abalaie abalaie left review comments

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@vandjelk vandjelk vandjelk left review comments

Assignees

@vandjelk vandjelk

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmitoraj @kyma-bot @vandjelk @dushanpantic @IwonaLanger @abalaie