Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Saving Graphql mutation object to Persistent Volume #3460

Merged
merged 23 commits into from
Aug 2, 2024
Merged

feat: Saving Graphql mutation object to Persistent Volume #3460

merged 23 commits into from
Aug 2, 2024

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Jul 18, 2024 •
edited by akgalwas
Loading

Description
To have a comparison app which will compare the Provisioner and KIM provisioning input request we need to store this input in PersistentVolume.

Changes proposed in this pull request:

  • dumping GraphQL query added
  • names aligned between KIM and Provisioner to make comparison possible

Related issue(s)
kyma-project/infrastructure-manager#185

@mvshao mvshao requested a review from a team as a code owner July 18, 2024 06:30
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@akgalwas akgalwas mentioned this pull request Jul 19, 2024
Closed
4 tasks
@akgalwas akgalwas self-requested a review July 19, 2024 11:35
@mvshao mvshao force-pushed the pvc-shoot-comparer branch from 926f030 to 8852579 Compare July 24, 2024 12:24
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2024
@mvshao mvshao changed the title feat: Saving Graphql call to Persistent Volume feat: Saving Gardener shoot object to Persistent Volume Jul 25, 2024
@akgalwas akgalwas changed the title feat: Saving Gardener shoot object to Persistent Volume feat: Saving Graphql mutation object to Persistent Volume Jul 30, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
m00g3n
m00g3n approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 2, 2024
@kyma-bot kyma-bot merged commit 58ab649 into kyma-project:main Aug 2, 2024
5 checks passed
@akgalwas akgalwas mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

Assignees

@akgalwas akgalwas

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvshao @m00g3n @akgalwas @kyma-bot