apply code review comments

kyma-project · Apr 8, 2024 · a1413cf · a1413cf
1 parent 139fb9b
commit a1413cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/lint-go.yml b/.github/workflows/lint-go.yml
@@ -4,7 +4,7 @@ on:
   pull_request:
     branches:
       - "main"
-      - "release-*"
+      - "release-**"
     paths-ignore:
       - "docs/**"
       - "**.md"
@@ -32,7 +32,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21 # This can be a specific version. E.g. 1.19 or 1.21.x
+          go-version: 1.22 # This can be a specific version. E.g. 1.19 or 1.21.x
 
       - name: Checkout code
         uses: actions/checkout@v4

diff --git a/internal/controller/operator/eventing/eventmesh_test.go b/internal/controller/operator/eventing/eventmesh_test.go
@@ -537,7 +537,7 @@ func Test_stopEventMeshSubManager(t *testing.T) {
 // TestGetSecretForPublisher verifies the successful and failing retrieval
 // of secrets.
 func Test_GetSecretForPublisher(t *testing.T) {
-	eventingNS := "eventingNS"
+	eventingNS := "eventingns"
 	secretFor := func(message, namespace []byte) *kcorev1.Secret {
 		secret := &kcorev1.Secret{
 			ObjectMeta: kmetav1.ObjectMeta{
@@ -933,7 +933,7 @@ func Test_SyncPublisherProxySecret(t *testing.T) {
 			}
 
 			// when
-			_, err := r.SyncPublisherProxySecret(context.Background(), "eventingNS", testcase.givenSecret)
+			_, err := r.SyncPublisherProxySecret(context.Background(), "eventingns", testcase.givenSecret)
 
 			// then
 			if testcase.wantErr {