Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests in eventmesh_test.go #334

Closed
muralov opened this issue Dec 14, 2023 · 1 comment · Fixed by #335 or #378
Closed

fix tests in eventmesh_test.go #334

muralov opened this issue Dec 14, 2023 · 1 comment · Fixed by #335 or #378
Assignees
Labels
area/eventing Issues or PRs related to eventing
Milestone

Comments

@muralov
Copy link
Contributor

muralov commented Dec 14, 2023

Description

During enabling linting (goerr113) we discovered that Test_reconcileEventMeshSubManager uses require.ErrorAs wrongly. The tests pass internal/controller/operator/eventing/eventmesh_test.go:322 even when the error returned was not the one required. Please check how to use require.ErrorAs and require.ErrorIs. In this require.ErrorIs is probably the right function to use.

Priority critical as the tests could potentially hide errors due to flawed implementation

Acceptance

  • enable linting with goerr113 for the entire file
  • validate all test cases
@muralov muralov self-assigned this Dec 14, 2023
@grischperl grischperl added the area/eventing Issues or PRs related to eventing label Dec 14, 2023
@muralov
Copy link
Contributor Author

muralov commented Dec 15, 2023

I removed the critical importance as business logic is correct, but the test should have been improved.

@muralov muralov linked a pull request Dec 15, 2023 that will close this issue
@grischperl grischperl reopened this Dec 22, 2023
@muralov muralov linked a pull request Jan 10, 2024 that will close this issue
@grischperl grischperl modified the milestones: 1.0.3, 1.1.0 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
2 participants