Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable goerr113 linting for EventMesh tests #378

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Jan 10, 2024

No description provided.

@muralov muralov requested a review from a team as a code owner January 10, 2024 08:15
@muralov muralov requested a review from marcobebway January 10, 2024 08:15
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@muralov muralov linked an issue Jan 10, 2024 that may be closed by this pull request
marcobebway
marcobebway previously approved these changes Jan 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2024
@muralov muralov force-pushed the enable-goerr113-linting2 branch from a627132 to 1147397 Compare January 11, 2024 08:29
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 11, 2024
@muralov muralov added lgtm Looks good to me! area/eventing Issues or PRs related to eventing labels Jan 11, 2024
@muralov
Copy link
Contributor Author

muralov commented Jan 11, 2024

/retest pull-eventing-manager-build

@kyma-bot
Copy link

@muralov: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-eventing-manager-build

Use /test all to run all jobs.

In response to this:

/retest pull-eventing-manager-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@muralov
Copy link
Contributor Author

muralov commented Jan 11, 2024

/test pull-eventing-manager-build

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 11, 2024
@kyma-bot kyma-bot merged commit f662163 into kyma-project:main Jan 11, 2024
8 checks passed
@muralov muralov deleted the enable-goerr113-linting2 branch January 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix tests in eventmesh_test.go
3 participants