Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EC package w/ EventingWebhookAuth Enabled by default #104

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Sep 20, 2023

Use EC EventingWebhookAuth Enabled by default. Document EventMesh test.

Issue: #103

@muralov muralov requested a review from a team as a code owner September 20, 2023 05:11
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2023
* Use EC latest package with eventing webhook auth enabled by default
* Document EventMesh tests
@muralov muralov requested a review from a team as a code owner September 22, 2023 05:04
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2023
@muralov muralov changed the title Set EVENTING_WEBHOOK_AUTH_ENABLED to true Use EC EventingWebhookAuth Enabled by default Sep 22, 2023
@muralov muralov changed the title Use EC EventingWebhookAuth Enabled by default Use EC package w/ EventingWebhookAuth Enabled by default Sep 22, 2023
@muralov muralov linked an issue Sep 22, 2023 that may be closed by this pull request
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2023
README.md Outdated
@@ -111,6 +111,11 @@ You’ll need a Kubernetes cluster to run against. You can use [k3d](https://k3d
```sh
kubectl apply -f config/samples/eventing-eval.yaml
```
5. [Optional] For EventMesh backend, env var `DOMAIN` has to be set to cluster domain in the deployment resource. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. [Optional] For EventMesh backend, env var `DOMAIN` has to be set to cluster domain in the deployment resource. For example:
5. [Optional] For EventMesh backend, set env var `DOMAIN` to the cluster domain in the deployment resource. For example:

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 25, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2023
@kyma-bot kyma-bot merged commit ad85d87 into kyma-project:main Sep 25, 2023
3 checks passed
@muralov muralov deleted the enable-webhook-auth branch September 25, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Event Mesh Subscription Creation
4 participants