generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EC package w/ EventingWebhookAuth Enabled by default #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Sep 20, 2023
* Use EC latest package with eventing webhook auth enabled by default * Document EventMesh tests
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Sep 22, 2023
muralov
changed the title
Set EVENTING_WEBHOOK_AUTH_ENABLED to true
Use EC EventingWebhookAuth Enabled by default
Sep 22, 2023
muralov
changed the title
Use EC EventingWebhookAuth Enabled by default
Use EC package w/ EventingWebhookAuth Enabled by default
Sep 22, 2023
friedrichwilken
previously approved these changes
Sep 25, 2023
NHingerl
reviewed
Sep 25, 2023
README.md
Outdated
@@ -111,6 +111,11 @@ You’ll need a Kubernetes cluster to run against. You can use [k3d](https://k3d | |||
```sh | |||
kubectl apply -f config/samples/eventing-eval.yaml | |||
``` | |||
5. [Optional] For EventMesh backend, env var `DOMAIN` has to be set to cluster domain in the deployment resource. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
5. [Optional] For EventMesh backend, env var `DOMAIN` has to be set to cluster domain in the deployment resource. For example: | |
5. [Optional] For EventMesh backend, set env var `DOMAIN` to the cluster domain in the deployment resource. For example: |
NHingerl
approved these changes
Sep 25, 2023
friedrichwilken
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use EC EventingWebhookAuth Enabled by default. Document EventMesh test.
Issue: #103