Add ApplicationCRD Enabled ENV in Publisher deployment #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
added
the
do-not-merge/hold
kyma-bot
added
the
size/M
kyma-bot
added
size/L
5 tasks
mfaizanse
removed
the
do-not-merge/hold
marcobebway
reviewed
Oct 5, 2023
pkg/k8s/client_test.go
Outdated
Comment on lines
552
to
559
| name: "should return not found error when CRD is missing in k8s", | ||
| givenCRDName: ApplicationCrdName, | ||
| wantNotFoundError: false, | ||
| }, | ||
| { | ||
| name: "should return correct CRD from k8s", | ||
| givenCRDName: "non-existing", | ||
| wantNotFoundError: true, |
There was a problem hiding this comment.
I think the names of the test cases are switched.
marcobebway
reviewed
Oct 5, 2023
Comment on lines
+4
to
+9
| // ApplicationCrdName defines the CRD name for Application of application-connector module. | ||
| ApplicationCrdName string = "applications.applicationconnector.kyma-project.io" | ||
| // ApplicationKind defines the Kind name for Application of application-connector module. | ||
| ApplicationKind string = "Application" | ||
| // ApplicationAPIVersion defines the API version for Application of application-connector module. | ||
| ApplicationAPIVersion string = "applicationconnector.kyma-project.io/v1alpha1" |
There was a problem hiding this comment.
Please check if the Kyma application connector package have similar constants or not, so we can reuse them.
There was a problem hiding this comment.
If they have than we have to import the pkg and keep bumping the version for security issues. Would it be okay to keep one variable of our own?
mfaizanse
requested review from
marcobebway
and removed request for
grischperl
marcobebway
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)