Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block eventing cr deletion #151

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Oct 18, 2023

Description

Changes proposed in this pull request:

Don't let the eventing CR be deleted if subscription CRs exist.

Related issue(s)
#79

* Block eventing module deletion if any subscription exists
* Implement tests
@muralov muralov requested a review from a team as a code owner October 18, 2023 08:21
@muralov muralov requested a review from marcobebway October 18, 2023 08:21
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2023
@muralov muralov linked an issue Oct 18, 2023 that may be closed by this pull request
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@muralov muralov requested review from mfaizanse and removed request for marcobebway October 18, 2023 14:12
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2023
@kyma-bot kyma-bot merged commit 1d3bae1 into kyma-project:main Oct 18, 2023
3 checks passed
@muralov muralov deleted the block-eventing-cr-deletion branch October 19, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block eventing-CR removal if resources owned by it exist in the cluster
3 participants