Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create UI for Eventing Module #166

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Create UI for Eventing Module #166

merged 9 commits into from
Oct 24, 2023

Conversation

grischperl
Copy link
Contributor

@grischperl grischperl commented Oct 19, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Create UI for Eventing Module

Related issue(s)

#120

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2023
@grischperl grischperl linked an issue Oct 20, 2023 that may be closed by this pull request
Create Eventing UI #120
Closed
12 tasks
@grischperl grischperl changed the title Add files for eventing UI Create UI for Eventing Module Oct 20, 2023
@grischperl grischperl marked this pull request as ready for review October 22, 2023 18:06
@grischperl grischperl requested a review from a team as a code owner October 22, 2023 18:06
@grischperl grischperl requested a review from muralov October 22, 2023 18:06
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2023
k15r
k15r reviewed Oct 23, 2023
View reviewed changes
config/ui-extensions/eventing/kustomization.yaml Outdated
@@ -0,0 +1,14 @@
configMapGenerator:
- name: operator.kyma-project.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name needs to be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it needs to be eventing.operator.kyma-project.io.

@grischperl
Fix name
906c9e5 
Consolidate UI to one folder
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2023
@grischperl
Copy link
Contributor Author

/retest

k15r
k15r previously approved these changes Oct 24, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2023
@k15r k15r added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2023
@k15r k15r removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Looks good to me! labels Oct 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2023
@kyma-bot kyma-bot merged commit a5e840c into kyma-project:main Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway marcobebway approved these changes

@k15r k15r k15r approved these changes

@muralov muralov Awaiting requested review from muralov muralov is a code owner automatically assigned from kyma-project/eventing

Assignees

@k15r k15r

@marcobebway marcobebway

Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Eventing UI
5 participants
@grischperl @kyma-bot @k15r @muralov @marcobebway