Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nats stream replica update #248

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Nov 15, 2023

Description

Fix nats stream replicas update

  • Set subscription manager to nil if spec is changed to create subscription manager with new values

Related issue(s)
#211

@muralov muralov requested a review from a team as a code owner November 15, 2023 14:25
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2023
@muralov muralov force-pushed the fix-stream-replica-update branch from 82aee38 to 98210c1 Compare November 16, 2023 12:51
Test the case when eventing CR changes but NATS sub manager failed to
start
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 16, 2023
@kyma-bot kyma-bot merged commit 16da476 into kyma-project:main Nov 16, 2023
5 checks passed
@muralov muralov linked an issue Nov 16, 2023 that may be closed by this pull request
1 task
friedrichwilken pushed a commit to friedrichwilken/eventing-manager that referenced this pull request Dec 14, 2023
* Fix nats stream replica update

* Add unit test for the fix

Test the case when eventing CR changes but NATS sub manager failed to
start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a nats cluster with just 1 node results in unready subscriptions
3 participants