Moved api pkg from eventing-controller #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
added
do-not-merge/hold
kyma-bot
added
the
size/XXL
mfaizanse
commented
Nov 20, 2023
| utils.WithEventingStreamData("Memory", "650M", 5, 5000), | ||
| utils.WithEventingEventTypePrefix("sap.kyma.custom"), | ||
| ) | ||
| givenEventing := &v1alpha1.Eventing{ |
There was a problem hiding this comment.
This is done to fix import cycle!!!
2 tasks
2 tasks
mfaizanse
commented
Nov 20, 2023
docs/user/02-configuration.md
Outdated
| | **publisher.​resources.​claims** | \[\]object | Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container. This is an alpha field and requires enabling the DynamicResourceAllocation feature gate. This field is immutable. It can only be set for containers. | | ||
| | **publisher.​resources.​claims.​name** (required) | string | Name must match the name of one entry in pod.spec.resourceClaims of the Pod where this field is used. It makes that resource available inside a container. | | ||
| | **publisher.​resources.​limits** | map\[string\]\{integer or string\} | Limits describes the maximum amount of compute resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ | | ||
| | Parameter | Type | Description | |
There was a problem hiding this comment.
Revert this file to version from main branch before getting approval.
muralov
previously approved these changes
Nov 24, 2023
IwonaLanger
previously approved these changes
Nov 24, 2023
muralov
added
area/eventing
muralov
force-pushed
the
move_code_part_6
branch
from
48310ed to
2942cbd
Compare
muralov
force-pushed
the
move_code_part_6
branch
from
2942cbd to
15f9524
Compare
muralov
approved these changes
Nov 27, 2023
NHingerl
approved these changes
Nov 27, 2023
friedrichwilken
pushed a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Dec 14, 2023
* Moved api pkg from eventing-controller * updated samples * Fix failing tests * Delete external CRD folder * Revert 02-configuration.md doc --------- Co-authored-by: Mansur Uralov <[email protected]>
friedrichwilken
pushed a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Dec 14, 2023
* Moved api pkg from eventing-controller * updated samples * Fix failing tests * Delete external CRD folder * Revert 02-configuration.md doc --------- Co-authored-by: Mansur Uralov <[email protected]>
friedrichwilken
pushed a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Dec 14, 2023
* Moved api pkg from eventing-controller * updated samples * Fix failing tests * Delete external CRD folder * Revert 02-configuration.md doc --------- Co-authored-by: Mansur Uralov <[email protected]>
friedrichwilken
pushed a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Dec 14, 2023
* Moved api pkg from eventing-controller * updated samples * Fix failing tests * Delete external CRD folder * Revert 02-configuration.md doc --------- Co-authored-by: Mansur Uralov <[email protected]>
kyma-bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Moved api pkg from eventing-controller (#260) * Moved api pkg from eventing-controller * updated samples * Fix failing tests * Delete external CRD folder * Revert 02-configuration.md doc --------- Co-authored-by: Mansur Uralov <[email protected]> * Cache runtime objects only created by the EventingManager (#273) * Cache runtime objects only created by the EventingManager * Update test case name * Semantic versioning in security scan config (#319) * check_image.sh * check_image.sh * release.sh * Remove `.version` file check in release * Call retry function * Refactoring * Verify status * Check tags in security-scan-config.yaml * Check on both place * Collect latest run related data * Checkout code (#323) * Release input variable for tag checking (#324) * Release input variable for tag checking (#326) * Release input variable for tag checking * Remove whitespace * Remove white space at rc-tag * Initial Wait Time (#327) * Initial Wait Time * Parameters * Remove first check * Run github action workflows on release-branches. (#330) * tidy go.mod * bump golangcli-lint vesion * bump release version --------- Co-authored-by: Muhammad Faizan <[email protected]> Co-authored-by: Mansur Uralov <[email protected]> Co-authored-by: Marco Bebway <[email protected]> Co-authored-by: Tibor Kiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request are mentioned here.
Related issue(s)
eventing-controllertoeventing-manager#106