Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use created-by label to cache runtime objects #275

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Use created-by label to cache runtime objects #275

merged 1 commit into from
Jan 11, 2024

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Nov 30, 2023 •
edited
Loading

Description

Use the app.kubernetes.io/created-by label to cache runtime objects.

⚠️ Caution ⚠️

This PR should be merged only after the label app.kubernetes.io/created-by=eventing-manager is released to PROD.

@marcobebway marcobebway requested a review from a team as a code owner November 30, 2023 16:42
@marcobebway marcobebway requested a review from muralov November 30, 2023 16:42
@marcobebway marcobebway self-assigned this Nov 30, 2023
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 30, 2023
@marcobebway marcobebway added area/eventing Issues or PRs related to eventing and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 30, 2023
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Nov 30, 2023
@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@marcobebway marcobebway marked this pull request as draft November 30, 2023 16:43
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@marcobebway
Copy link
Contributor Author

/test all

@marcobebway
Copy link
Contributor Author

/retest

@marcobebway marcobebway requested review from k15r and removed request for muralov December 1, 2023 13:33
@marcobebway marcobebway force-pushed the use-created-by-label-to-cache-runtime-objects branch from c67a4ff to ea463b2 Compare December 5, 2023 19:29
@marcobebway
Copy link
Contributor Author

/test all

@marcobebway marcobebway force-pushed the use-created-by-label-to-cache-runtime-objects branch from ea463b2 to 78ec8b6 Compare January 9, 2024 14:36
@marcobebway marcobebway marked this pull request as ready for review January 9, 2024 14:44
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024
@marcobebway
Copy link
Contributor Author

/retest

@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@marcobebway marcobebway removed the request for review from k15r January 11, 2024 10:50
@muralov muralov self-requested a review January 11, 2024 12:16
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 11, 2024
@kyma-bot kyma-bot merged commit 384036d into kyma-project:main Jan 11, 2024
8 checks passed
@grischperl grischperl modified the milestones: 1.0.3, 1.1.0 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov approved these changes

Assignees

@muralov muralov

@marcobebway marcobebway

Labels
area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@marcobebway @muralov @kyma-bot @grischperl