Add publisher service in the Eventing CR status #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
marcobebway
added
area/eventing
kyma-bot
added
size/L
marcobebway
force-pushed
the
270-add-publish-endpoint-to-eventing-cr-status
branch
2 times, most recently
from
a28f691 to
61d5148
Compare
|
/hold |
kyma-bot
added
the
do-not-merge/hold
marcobebway
force-pushed
the
270-add-publish-endpoint-to-eventing-cr-status
branch
4 times, most recently
from
e8ab0ec to
d5497c0
Compare
marcobebway
force-pushed
the
270-add-publish-endpoint-to-eventing-cr-status
branch
from
d5497c0 to
cc88e69
Compare
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
NHingerl
approved these changes
Dec 7, 2023
|
/hold |
kyma-bot
added
the
do-not-merge/hold
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
grischperl
approved these changes
Dec 8, 2023
| @@ -153,29 +154,37 @@ func (r *Reconciler) updateStatus(ctx context.Context, oldEventing, newEventing | |||
| return nil | |||
| } | |||
|
|
|||
| func (r *Reconciler) handleEventingState(ctx context.Context, deployment *kappsv1.Deployment, eventing *operatorv1alpha1.Eventing, log *zap.SugaredLogger) (kctrl.Result, error) { | |||
| func (r *Reconciler) handleEventingState(ctx context.Context, deployment *kappsv1.Deployment, | |||
| eventingCR *operatorv1alpha1.Eventing, log *zap.SugaredLogger, | |||
There was a problem hiding this comment.
nit: eventingCR is nicer, but I think everywhere else it's called eventing. Keep it eventingCR here, but open an issue for consistent naming?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add publisher service in the Eventing CR status.
Related issue(s)