Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI with improved notifications #286

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Update UI with improved notifications #286

merged 5 commits into from
Dec 8, 2023

Conversation

grischperl
Copy link
Contributor

@grischperl grischperl commented Dec 6, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Selecting the nats-backend option via Busola displays a notification that requires the user to activate the nats module.
  • Having no backend selected displays a notification that requires the user to configure a backend.
  • Once a backend is selected, all modules are installed and the Eventing module is ready, no notifications are displayed.
  • In the overview, if the Eventing module is in warning state, a notification points to the docu/error messages.

Related issue(s)

#266

@grischperl grischperl requested a review from a team as a code owner December 6, 2023 16:53
@grischperl grischperl requested a review from muralov December 6, 2023 16:53
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 6, 2023
@grischperl grischperl linked an issue Dec 6, 2023 that may be closed by this pull request
Allow empty backend-spec on eventing-cr #266
Closed
6 tasks
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@grischperl grischperl changed the title Nats backend notification Update UI with improved notifications Dec 6, 2023
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@muralov muralov added the area/eventing Issues or PRs related to eventing label Dec 8, 2023
@kyma-bot kyma-bot merged commit def15e8 into kyma-project:main Dec 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov approved these changes

Assignees

@muralov muralov

Labels
area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty backend-spec on eventing-cr
3 participants
@grischperl @muralov @kyma-bot