enable more linters #288
Merged
enable more linters #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
kyma-bot
added
size/XL
kyma-bot
removed
the
do-not-merge/work-in-progress
mfaizanse
requested review from
mfaizanse
and removed request for
grischperl
kyma-bot
added
size/XXL
mfaizanse
reviewed
Dec 15, 2023
| @@ -86,8 +86,8 @@ func TestNewDeployment(t *testing.T) { | |||
| container := findPublisherContainer(publisherName, *deployment) | |||
| assert.NotNil(t, container) | |||
|
|
|||
| assert.Equal(t, fmt.Sprint(container.Name), publisherName) | |||
| assert.Equal(t, fmt.Sprint(container.Image), publisherConfig.Image) | |||
| assert.Equal(t, container.Name, publisherName) | |||
There was a problem hiding this comment.
(nit) Should we change assert by require?
There was a problem hiding this comment.
that would change the behaviour of the test, so i avoided it
mfaizanse
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
lintMakefile target to download a specific version of golangci-lintlint-fixMakefile target. This target runs golangci-lint with fixing enabled. Certain linters will not complain, but actually fix the issues. Run this target togciandgofumptyour filesRelated issue(s)