Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Warning State #317

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Dec 12, 2023

Write documentation in which cases Eventing CR state gets Warning state

Write documentation in which cases Eventing CR state gets Warning state
@muralov muralov requested review from a team as code owners December 12, 2023 06:45
@muralov muralov requested a review from mfaizanse December 12, 2023 06:45
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2023
@muralov muralov requested review from grischperl and removed request for mfaizanse December 12, 2023 06:46
api/operator/v1alpha1/eventing_types.go Outdated Show resolved Hide resolved
docs/user/02-configuration.md Outdated Show resolved Hide resolved
docs/user/02-configuration.md Outdated Show resolved Hide resolved
@muralov
Copy link
Contributor Author

muralov commented Dec 12, 2023

The difference between error and warning isn't clear; or rather, the condition for error state remains very vague (while warning is very very specific).
Can we make this clearer, or is this just the way it is? (in that case, I'm not sure "the way it is" is ideal)

I understand you that there is little difference. We had different opinions about it, but decided to do like this. I just documented the requirement here what was written in the issue. Unfortunatley this is the way it is.

NHingerl
NHingerl previously approved these changes Dec 12, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2023
ActiveBackend BackendType `json:"activeBackend"`
BackendConfigHash int64 `json:"specHash"`
// Can have one of the following values: Ready, Error, Processing, Warning. Ready state is set
// when all the resources are deployed successfully and backend is connected.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct right now? It might change together with: #267

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is independen from the issue. The owner of the issue should add more details as the issue is completed, I'd say.

api/operator/v1alpha1/eventing_types.go Outdated Show resolved Hide resolved
@grischperl grischperl linked an issue Dec 12, 2023 that may be closed by this pull request
6 tasks
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 12, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 12, 2023
@muralov muralov added the area/eventing Issues or PRs related to eventing label Dec 12, 2023
@kyma-bot kyma-bot merged commit 949ce03 into kyma-project:main Dec 12, 2023
9 checks passed
@muralov muralov deleted the doc-empty-eventing-cr branch December 13, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/eventing Issues or PRs related to eventing cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty backend-spec on eventing-cr
4 participants