Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Eventing States More Detailed #328

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Dec 14, 2023

More detailed documentation of the Eventin CR state

@muralov muralov requested review from a team as code owners December 14, 2023 06:19
@muralov muralov requested a review from marcobebway December 14, 2023 06:19
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2023
api/operator/v1alpha1/eventing_types.go Outdated Show resolved Hide resolved
docs/user/02-configuration.md Outdated Show resolved Hide resolved
@marcobebway marcobebway requested review from a team and removed request for marcobebway December 14, 2023 09:35
@muralov muralov requested a review from k15r December 14, 2023 10:34
@k15r k15r linked an issue Dec 15, 2023 that may be closed by this pull request

Warnings indicate that user action is required, that is, the user must install the NATS module or create an EventMesh Secret.

| Backend Config | Backend State | State |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea of this ticket was to clearly document which combination of settings will cause what sort of state
eg:


EV-configuration backend: NATS
NATS cluster: not available
resulting EV-STATE: ? (no events will be accepted / dispatched)


EV backend: NATS
NATSCluster: available (even if the NATS-module is currently being deleted)
Eventing: READY (events will still be accepted / dispatched)

....

Copy link
Contributor Author

@muralov muralov Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second case you mentioned is still under development. I either document and wait until Marco is finished, or Marco will document it here. What do do think?

@grischperl grischperl added this to the 1.2.0 milestone Feb 4, 2024
@muralov muralov force-pushed the doc-more-about-state branch from 54b42e1 to 415d571 Compare February 6, 2024 05:35
@grischperl grischperl removed this from the 1.2.0 milestone Feb 6, 2024
@muralov muralov force-pushed the doc-more-about-state branch from 415d571 to 05411aa Compare February 6, 2024 19:32
docs/user/02-configuration.md Outdated Show resolved Hide resolved

Warnings indicate that user action is required, that is, the user must install the NATS module or create an EventMesh Secret.

| Backend Config | Backend State | Backend Type | Eventing State | Addition comment |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho it would be easier to grep if we would sort the table by impact on event flow.

docs/user/02-configuration.md Outdated Show resolved Hide resolved
docs/user/02-configuration.md Outdated Show resolved Hide resolved
@muralov muralov force-pushed the doc-more-about-state branch from 05411aa to 779208d Compare February 15, 2024 11:04
Comment on lines 90 to 96
| exists | Error (NATS ist unavailable or cannot be connected) | NATS | Warning | no events will be accepted / dispatched |
| missing | | NATS/EventMesh | Warning | no events will be accepted / dispatched |
| exists | Error (secret for EventMesh missing) | EventMesh | Warning | no events will be accepted / dispatched |
| exists | Error (cases not caused by a user, e.g. cannot create EPP deployment or cannot start subscription manager although backend is available) | NATS/EventMesh | Error | no events will be accepted / dispatched |
| exists | Processing (mainly happens during initialization and backend switching) | NATS/EventMesh | Processing | no events will be accepted / dispatched |
| exists | Missing | NATS | Warning | no events will be accepted / dispatched |
| exists | Warning (NATS deletion blocked) | NATS | Ready | events will be accepted / dispatched |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| exists | Error (NATS ist unavailable or cannot be connected) | NATS | Warning | no events will be accepted / dispatched |
| missing | | NATS/EventMesh | Warning | no events will be accepted / dispatched |
| exists | Error (secret for EventMesh missing) | EventMesh | Warning | no events will be accepted / dispatched |
| exists | Error (cases not caused by a user, e.g. cannot create EPP deployment or cannot start subscription manager although backend is available) | NATS/EventMesh | Error | no events will be accepted / dispatched |
| exists | Processing (mainly happens during initialization and backend switching) | NATS/EventMesh | Processing | no events will be accepted / dispatched |
| exists | Missing | NATS | Warning | no events will be accepted / dispatched |
| exists | Warning (NATS deletion blocked) | NATS | Ready | events will be accepted / dispatched |
| exists | Warning (NATS deletion blocked) | NATS | Ready | events will be accepted / dispatched |
| exists | Processing (mainly happens during initialization and backend switching) | NATS/EventMesh | Processing | no events will be accepted / dispatched |
| exists | Error (NATS ist unavailable or cannot be connected) | NATS | Warning | no events will be accepted / dispatched |
| missing | | NATS/EventMesh | Warning | no events will be accepted / dispatched |
| exists | Missing | NATS | Warning | no events will be accepted / dispatched |
| exists | Error (secret for EventMesh missing) | EventMesh | Warning | no events will be accepted / dispatched |
| exists | Error (cases not caused by a user, e.g. cannot create EPP deployment or cannot start subscription manager although backend is available) | NATS/EventMesh | Error | no events will be accepted / dispatched |

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 15, 2024
@kyma-bot kyma-bot merged commit bdf31bc into kyma-project:main Feb 15, 2024
15 checks passed
@muralov muralov deleted the doc-more-about-state branch February 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance documentation for states of eventing-CR
5 participants