remove call of make module-build #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really only need to render the manifests so lets remove module-build.
kyma-bot
added
area/ci
grischperl
approved these changes
Dec 15, 2023
friedrichwilken
added a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Dec 15, 2023
* remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY
kyma-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
* fix reference to release name (#342) * add missing env vars for IMG and MODULE_REGISTERY (#343) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * add KUSTOMIZE_VERSION * fix wrong token (#344) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * replace the BOT_GITHUB_TOKEN with the GITHUB_TOKEN * remove call of make module-build (#347) * remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY * fix spelling of env var name (#348)
friedrichwilken
added a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Jan 15, 2024
* remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY
kyma-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Fix release of manifests (#340) (#341) * clean up create-release.yml Clean up the create-release.yml by removing a number of unused and outcommented lines. * rename release.sh to render_and_upload_manifests.sh Rename the scripts/release.sh to render_and_upload_manifests.sh to point clearly out, what the script is about. * call manifest release from create-release.yml Call the render_and_upload_manifests.sh because it no longer created by a prow job. * deactivate module-template upload Deactivate the upload of the module-template. All functionality for the module-template will be removed eventually, in a follow up PR. * fix reference of env var * fix reference to release name (#342) * add missing env vars for IMG and MODULE_REGISTERY (#343) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * add KUSTOMIZE_VERSION * fix wrong token (#344) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * replace the BOT_GITHUB_TOKEN with the GITHUB_TOKEN * remove call of make module-build (#347) * remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY * fix spelling of env var name (#348) * release-without-version-input * improve check_sec-scanners-config.sh rename from check_tag_info.sh to check_sec-scanners-config.sh and add error handling and desciption. * clean up
friedrichwilken
added a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Jan 16, 2024
* Fix release of manifests (kyma-project#340) (kyma-project#341) * clean up create-release.yml Clean up the create-release.yml by removing a number of unused and outcommented lines. * rename release.sh to render_and_upload_manifests.sh Rename the scripts/release.sh to render_and_upload_manifests.sh to point clearly out, what the script is about. * call manifest release from create-release.yml Call the render_and_upload_manifests.sh because it no longer created by a prow job. * deactivate module-template upload Deactivate the upload of the module-template. All functionality for the module-template will be removed eventually, in a follow up PR. * fix reference of env var * fix reference to release name (kyma-project#342) * add missing env vars for IMG and MODULE_REGISTERY (kyma-project#343) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * add KUSTOMIZE_VERSION * fix wrong token (kyma-project#344) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * replace the BOT_GITHUB_TOKEN with the GITHUB_TOKEN * remove call of make module-build (kyma-project#347) * remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY * fix spelling of env var name (kyma-project#348) * release-without-version-input * improve check_sec-scanners-config.sh rename from check_tag_info.sh to check_sec-scanners-config.sh and add error handling and desciption. * clean up
friedrichwilken
added a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Jan 16, 2024
* Fix release of manifests (kyma-project#340) (kyma-project#341) * clean up create-release.yml Clean up the create-release.yml by removing a number of unused and outcommented lines. * rename release.sh to render_and_upload_manifests.sh Rename the scripts/release.sh to render_and_upload_manifests.sh to point clearly out, what the script is about. * call manifest release from create-release.yml Call the render_and_upload_manifests.sh because it no longer created by a prow job. * deactivate module-template upload Deactivate the upload of the module-template. All functionality for the module-template will be removed eventually, in a follow up PR. * fix reference of env var * fix reference to release name (kyma-project#342) * add missing env vars for IMG and MODULE_REGISTERY (kyma-project#343) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * add KUSTOMIZE_VERSION * fix wrong token (kyma-project#344) * add missing env vars for IMG and MODULE_REGISTERY * remove arg * replace the BOT_GITHUB_TOKEN with the GITHUB_TOKEN * remove call of make module-build (kyma-project#347) * remove call of make module-build We really only need to render the manifests so lets remove module-build. * revert removal of MODULE_REGISTERY * fix spelling of env var name (kyma-project#348) * release-without-version-input * improve check_sec-scanners-config.sh rename from check_tag_info.sh to check_sec-scanners-config.sh and add error handling and desciption. * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really only need to render the manifests so lets remove module-build.
Description
in the release action, we do not need make build module, so let's remove it.
Changes proposed in this pull request:
make build-moduleRelated issue(s)