Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable more linters (part 4) #354

Merged
merged 15 commits into from
Dec 22, 2023
Merged

enable more linters (part 4) #354

merged 15 commits into from
Dec 22, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Dec 19, 2023

Description

Changes proposed in this pull request:

  • enable gochecknoglobals
  • enable gochecknoinits
  • enable noctx
  • enable godox
  • enable ginkgolinter
  • enable errorlint
  • enable stylecheck
  • enable gomnd
  • enable gocritic
  • enable thelper
  • enable godot
  • enable gocognit
  • enable staticcheck
  • enable goconst
  • enable unparam

Related issue(s)

@k15r k15r requested a review from a team as a code owner December 19, 2023 12:32
@k15r k15r requested a review from grischperl December 19, 2023 12:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2023
@k15r k15r changed the title more linters part4 enable more linters (part 4) Dec 19, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 22, 2023
@kyma-bot kyma-bot merged commit d7a0850 into kyma-project:main Dec 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grischperl grischperl grischperl approved these changes

Assignees

@grischperl grischperl

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k15r @grischperl @kyma-bot