Fix e2e job NATS Install step #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
area/ci
kyma-bot
added
size/S
the1bit
approved these changes
Jan 10, 2024
marcobebway
approved these changes
Jan 11, 2024
| @@ -210,8 +210,10 @@ func (m *EventMeshMock) handleMessaging() func(w http.ResponseWriter, r *http.Re | |||
| if err == nil { | |||
| break | |||
| } | |||
| if i < 2 { // Don't sleep after the last attempt | |||
| time.Sleep(3 * time.Second) | |||
| two := 2 | |||
There was a problem hiding this comment.
maybe attempts is a better name.
|
Can we have a better description here the next time? A reason like "The job x is broken (link) because of reasons. To fix that this PR does this and that?" |
yes, I'll try to add more details next time. |
friedrichwilken
pushed a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Jan 16, 2024
* Fix e2e job NATS Install step * Fix magic number linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install NATS module without lifecycle manager.
Reason: