Init for backend switching action #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
added
do-not-merge/hold
kyma-bot
added
cla: yes
mfaizanse
removed
the
do-not-merge/hold
marcobebway
reviewed
Jan 12, 2024
| @@ -0,0 +1,36 @@ | |||
| name: e2e-on-k8s | |||
There was a problem hiding this comment.
we have another workflow e2e-without-lifecycle-manager, which should be renamed to e2e IMO. Thats why I added the k8s to convey the msg that this workflow uses real k8s on gardener.
There was a problem hiding this comment.
Is e2e-without-lifecycle-manager also running on gardener?
There was a problem hiding this comment.
How about we use the following prefixes when it make sense e2e-k3d e2e-gardener?
There was a problem hiding this comment.
I will do it in next PR.
marcobebway
reviewed
Jan 12, 2024
| pull_request_target: | ||
| branches: | ||
| - main | ||
| - "release-*" |
There was a problem hiding this comment.
Is this understandable by gh-workflows? because it is not a valid regex.
There was a problem hiding this comment.
I copied it from the other workflow. But I am sure atm, I will confirm this.
marcobebway
approved these changes
Jan 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
wait-until-build-succeedsaction to centralize waiting for build prow job.Related issue(s)