Code cleanup #399
Merged
Code cleanup #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichwilken
added
the
do-not-merge/hold
kyma-bot
added
size/M
friedrichwilken
force-pushed
the
code-cleanup
branch
from
c56c394 to
c0b7fef
Compare
The name `install-nats-module` is a little misleading, since this target does not work with modules, but with the CR and CRD of the NATS-manager.
A lot of make targets have become obsolete since a release of eventing-manager or nats-manger does no longer generate a module-template. For that reason, all targets that work with modules can be removed.
friedrichwilken
force-pushed
the
code-cleanup
branch
from
c0b7fef to
d8f7baa
Compare
kyma-bot
added
size/L
friedrichwilken
removed
the
do-not-merge/hold
mfaizanse
reviewed
Jan 16, 2024
mfaizanse
reviewed
Jan 16, 2024
mfaizanse
reviewed
Jan 16, 2024
mmitoraj
previously approved these changes
Jan 16, 2024
mfaizanse
approved these changes
Jan 16, 2024
the1bit
approved these changes
Jan 16, 2024
NHingerl
approved these changes
Jan 16, 2024
friedrichwilken
added a commit
to friedrichwilken/eventing-manager
that referenced
this pull request
Jan 16, 2024
* rename variables * rename make target The name `install-nats-module` is a little misleading, since this target does not work with modules, but with the CR and CRD of the NATS-manager. * remove unused make targets A lot of make targets have become obsolete since a release of eventing-manager or nats-manger does no longer generate a module-template. For that reason, all targets that work with modules can be removed. * remove module specific secitons in the readme * revert changes for make target name * make variables to consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the sake of code quality, this PR cleans up some areas of the code base.
Changes proposed in this pull request:
Tests
Any issues that would have been created by this PR would be caught by the existing tests.
Related issue(s)
None