Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken release workflow #415

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix broken release workflow #415

merged 1 commit into from
Jan 18, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Jan 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fix a missing ) in the Create release workflow

Related issue(s)

@friedrichwilken friedrichwilken requested review from the1bit and a team as code owners January 18, 2024 10:07
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2024
@kyma-bot kyma-bot merged commit 73f9a94 into kyma-project:release-1.1 Jan 18, 2024
12 checks passed
friedrichwilken added a commit to friedrichwilken/eventing-manager that referenced this pull request Jan 18, 2024
@friedrichwilken
fix broken release workflow (kyma-project#415)
bb5d304
@friedrichwilken friedrichwilken mentioned this pull request Jan 18, 2024
Merged
kyma-bot pushed a commit that referenced this pull request Jan 18, 2024
@friedrichwilken @grischperl
Cherry pick changes to release workflow (#418)
3c84f14 
* Use correct job name in release workflow (#413)

* Bump eventing-manager image version for 1.1.0 release

* Use correct job name in release workflow

* fix broken release workflow (#415)

* fix the setting of env var PULL_BASE_REF in `Create release` (#416)

* Correct `manager.yaml` name (#417)

* Correct `manager.yaml` name

* Correct the name of `manager.yaml` in all files

---------

Co-authored-by: Carina Kothe <[email protected]>
@friedrichwilken friedrichwilken deleted the fix-broken-release-workflow branch February 3, 2024 08:13
@grischperl grischperl modified the milestone: 1.2.0 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grischperl grischperl grischperl approved these changes

@the1bit the1bit Awaiting requested review from the1bit the1bit is a code owner

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway is a code owner automatically assigned from kyma-project/eventing

Assignees

@grischperl grischperl

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friedrichwilken @grischperl @kyma-bot