Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick changes to release workflow #418

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Cherry pick changes to release workflow #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
759e340
Use correct job name in release workflow (#413)
grischperl Jan 18, 2024
bb5d304
fix broken release workflow (#415)
friedrichwilken Jan 18, 2024
e0e16d7
fix the setting of env var PULL_BASE_REF in `Create release` (#416)
friedrichwilken Jan 18, 2024
e1e0458
Correct `manager.yaml` name (#417)
grischperl Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/create-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

create-draft:
name: Create draft release
needs: verify-head-status
needs: verify-release
runs-on: ubuntu-latest
env:
VERSION: ${{ needs.verify-release.outputs.VERSION }}
Expand All @@ -58,7 +58,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
RELEASE_ID=$(./scripts/create_draft_release.sh $VERSION
RELEASE_ID=$(./scripts/create_draft_release.sh $VERSION)
echo "release_id=$RELEASE_ID" >> $GITHUB_OUTPUT

- name: Create lightweight tag
Expand All @@ -71,7 +71,7 @@ jobs:

- name: Create and upload eventing-manager.yaml and eventing-default-cr.yaml
env:
PULL_BASE_REF: $VERSION
PULL_BASE_REF: ${{ needs.verify-release.outputs.VERSION }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
IMG: "europe-docker.pkg.dev/kyma-project/prod/eventing-manager:${VERSION}"
MODULE_REGISTRY: "europe-docker.pkg.dev/kyma-project/prod/unsigned"
Expand All @@ -81,7 +81,7 @@ jobs:

publish-release:
name: Publish release
needs: [verify-head-status, create-draft]
needs: [verify-release, create-draft]
runs-on: ubuntu-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ You need a Kubernetes cluster to run against. You can use [k3d](https://k3d.io/)
2. To install the latest version of the default Eventing custom resource (CR) on your cluster, run:

```bash
kubectl apply -f https://github.com/kyma-project/eventing-manager/releases/latest/download/eventing_default_cr.yaml
kubectl apply -f https://github.com/kyma-project/eventing-manager/releases/latest/download/eventing-default-cr.yaml
```

## Development
Expand Down
2 changes: 1 addition & 1 deletion scripts/cleanup_modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ log::banner "Deleting all API Rules"
kubectl delete --timeout=120s --wait=false -A apirules.gateway.kyma-project.io --all

log::banner "Uninstalling Eventing module"
kubectl delete --timeout=120s --ignore-not-found -f https://github.com/kyma-project/eventing-manager/releases/latest/download/eventing_default_cr.yaml
kubectl delete --timeout=120s --ignore-not-found -f https://github.com/kyma-project/eventing-manager/releases/latest/download/eventing-default-cr.yaml
make undeploy

log::banner "Uninstalling NATS module"
Expand Down
2 changes: 1 addition & 1 deletion scripts/render_and_upload_manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ UPLOAD_URL="https://uploads.github.com/repos/kyma-project/eventing-manager/relea
uploadFile "eventing-manager.yaml" "${UPLOAD_URL}?name=eventing-manager.yaml"
# TODO completly remove the rendering of the module-template from the repository.
# uploadFile "module-template.yaml" "${UPLOAD_URL}?name=module-template.yaml"
uploadFile "config/samples/default.yaml" "${UPLOAD_URL}?name=eventing_default_cr.yaml"
uploadFile "config/samples/default.yaml" "${UPLOAD_URL}?name=eventing-default-cr.yaml"