Change Eventing CR status to WARN if cannot connect to NATS #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
|
/hold |
kyma-bot
added
the
do-not-merge/hold
muralov
reviewed
Feb 5, 2024
| ) | ||
| } | ||
|
|
||
| return kctrl.Result{}, r.syncStatusWithNATSErr(ctx, eventingCR, connErr, log) | ||
| return kctrl.Result{}, r.syncStatusWithNATSState(ctx, operatorv1alpha1.StateWarning, eventingCR, connErr, log) |
There was a problem hiding this comment.
Do we have test case for this case too? I see we have only for ErrCannotConnect error.
kyma-bot
added
size/M
marcobebway
force-pushed
the
267-fix-eventing-status
branch
2 times, most recently
from
82ada0e to
af0e513
Compare
marcobebway
force-pushed
the
267-fix-eventing-status
branch
from
af0e513 to
379be11
Compare
muralov
approved these changes
Feb 6, 2024
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Eventing CR status to WARN if cannot connect to NATS, because this is something the Eventing user can fix. As part of this PR, I removed unused function calls from the connection mock.
Related issue(s)
in deletion stateresults in eventing-cr inerrorstate #267